Skip to content

rustup #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 8, 2019
Merged

rustup #1040

merged 4 commits into from
Nov 8, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 7, 2019

No description provided.

@RalfJung
Copy link
Member Author

RalfJung commented Nov 7, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Nov 7, 2019

📌 Commit 428fc53 has been approved by RalfJung

@RalfJung RalfJung mentioned this pull request Nov 7, 2019
Closed
@bors
Copy link
Contributor

bors commented Nov 7, 2019

⌛ Testing commit 428fc53 with merge 7743a3e...

bors added a commit that referenced this pull request Nov 7, 2019
@bors
Auto merge of #1040 - RalfJung:rustup, r=RalfJung
7743a3e 
silence a lint that catches the bug statically
@bors
Copy link
Contributor

bors commented Nov 7, 2019

💔 Test failed - status-appveyor

@RalfJung
Copy link
Member Author

RalfJung commented Nov 7, 2019

Ah... this is running into the less conservative validation that now no longer accepts uninitialized raw pointers (but still accepts uninitialized integers). num_cpus gets that wrong.

@RalfJung
Copy link
Member Author

RalfJung commented Nov 8, 2019

Disabled a test on Windows for now until seanmonstar/num_cpus#90 lands and gets released.

@bors r+

@bors
Copy link
Contributor

bors commented Nov 8, 2019

📌 Commit a90ac3b has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Nov 8, 2019

⌛ Testing commit a90ac3b with merge b5fba6d...

bors added a commit that referenced this pull request Nov 8, 2019
@bors
Auto merge of #1040 - RalfJung:rustup, r=RalfJung
b5fba6d 
silence a lint that catches the bug statically
@bors
Copy link
Contributor

bors commented Nov 8, 2019

💔 Test failed - status-appveyor

@RalfJung
Copy link
Member Author

RalfJung commented Nov 8, 2019

Uh, that's odd

      libcompiler_builtins-79d2aa955c1ffe3b.rlib(compiler_builtins-79d2aa955c1ffe3b.compiler_builtins.2tl4fy26-cgu.5.rcgu.o) : error LNK2019: unresolved external symbol __sync_val_compare_and_swap_16 referenced in function __llvm_memcpy_element_unordered_atomic_16
          libcompiler_builtins-79d2aa955c1ffe3b.rlib(compiler_builtins-79d2aa955c1ffe3b.compiler_builtins.2tl4fy26-cgu.5.rcgu.o) : error LNK2019: unresolved external symbol __sync_lock_test_and_set_16 referenced in function __llvm_memcpy_element_unordered_atomic_16
          C:\Users\appveyor\AppData\Local\Temp\1\xargo.TsJ5fpBqjZ85\target\x86_64-pc-windows-msvc\release\deps\std.dll : fatal error LNK1120: 2 unresolved externals

@bors retry

bors added a commit that referenced this pull request Nov 8, 2019
@bors
Auto merge of #1040 - RalfJung:rustup, r=RalfJung
b67e444 
silence a lint that catches the bug statically
@bors
Copy link
Contributor

bors commented Nov 8, 2019

⌛ Testing commit a90ac3b with merge b67e444...

@RalfJung
Copy link
Member Author

RalfJung commented Nov 8, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Nov 8, 2019

📌 Commit bcbc666 has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Nov 8, 2019

⌛ Testing commit bcbc666 with merge f10287b...

bors added a commit that referenced this pull request Nov 8, 2019
@bors
Auto merge of #1040 - RalfJung:rustup, r=RalfJung
f10287b 
silence a lint that catches the bug statically
@bors
Copy link
Contributor

bors commented Nov 8, 2019

💔 Test failed - status-appveyor

@RalfJung RalfJung changed the title silence a lint that catches the bug statically rustup Nov 8, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Nov 8, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Nov 8, 2019

📌 Commit 4c25cf0 has been approved by RalfJung

bors added a commit that referenced this pull request Nov 8, 2019
@bors
Auto merge of #1040 - RalfJung:rustup, r=RalfJung
624d751 
rustup
@bors
Copy link
Contributor

bors commented Nov 8, 2019

⌛ Testing commit 4c25cf0 with merge 624d751...

@bors
Copy link
Contributor

bors commented Nov 8, 2019

💔 Test failed - status-appveyor

@RalfJung
Copy link
Member Author

RalfJung commented Nov 8, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Nov 8, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Nov 8, 2019

📌 Commit 4c25cf0 has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Nov 8, 2019

⌛ Testing commit 4c25cf0 with merge 9316d90...

bors added a commit that referenced this pull request Nov 8, 2019
@bors
Auto merge of #1040 - RalfJung:rustup, r=RalfJung
9316d90 
rustup
@bors
Copy link
Contributor

bors commented Nov 8, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 9316d90 to master...

@bors bors merged commit 4c25cf0 into rust-lang:master Nov 8, 2019
@RalfJung RalfJung deleted the rustup branch November 8, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RalfJung @bors